The intent is if there is no regulator should hit this if statement.

+       if (IS_ERR(host->vqmmc)) {
+               pr_info("%s: no vqmmc regulator found\n", mmc_hostname(mmc));
+               host->vqmmc = NULL;


On Oct 30, 2012, at 9:56 PM, Daniel Drake <d...@laptop.org> wrote:

> On Tue, Oct 30, 2012 at 2:37 PM, Philip Rakity <prak...@nvidia.com> wrote:
>> Intentional.
>> 
>> if no vqmmc regulator then just assume it will work.
> 
> When you say "it", do you mean "UHS-I support"?
> The code in this case will *disable* UHS-I support, because these lines are 
> hit.
> +               caps[1] &= ~(SDHCI_SUPPORT_SDR104 | SDHCI_SUPPORT_SDR50 |
> +                      SDHCI_SUPPORT_DDR50);
> 
>> if there is a regulator it needs to support 1.8V.  (If I remember correctly 
>> UHS mode require 1.8V vccq)  I need to check if we 1.2V should be allowed 
>> but it was not in the spec that I had.
> 
> I'm asking about the case when there is no regulator.
> 
> Thanks
> Daniel

-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may 
contain
confidential information.  Any unauthorized review, use, disclosure or 
distribution
is prohibited.  If you are not the intended recipient, please contact the 
sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to