> -----Original Message----- > From: Linux-nvdimm <linux-nvdimm-boun...@lists.01.org> On Behalf Of > Dave Jiang > Sent: Friday, November 09, 2018 4:14 PM > Subject: [PATCH 07/11] libnvdimm/security: add overwrite status > notification > ... > @@ -2033,6 +2033,11 @@ static int acpi_nfit_register_dimms(struct > acpi_nfit_desc *acpi_desc) > if (!nvdimm) > continue; > > + rc = nvdimm_setup_security_events(nvdimm); > + if (rc < 0) > + dev_warn(acpi_desc->dev, > + "no security event setup > failed\n");
That seems like a double negative. Printing the rc value (or better yet, the string for it) is always helpful too. --- Robert Elliott, HPE Persistent Memory _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
