On 11/9/18 7:59 PM, Elliott, Robert (Persistent Memory) wrote: >> -----Original Message----- >> From: Linux-nvdimm <linux-nvdimm-boun...@lists.01.org> On Behalf Of >> Dave Jiang >> Sent: Friday, November 09, 2018 4:14 PM >> Subject: [PATCH 07/11] libnvdimm/security: add overwrite status >> notification >> > ... >> @@ -2033,6 +2033,11 @@ static int acpi_nfit_register_dimms(struct >> acpi_nfit_desc *acpi_desc) >> if (!nvdimm) >> continue; >> >> +rc = nvdimm_setup_security_events(nvdimm); >> +if (rc < 0) >> +dev_warn(acpi_desc->dev, >> +"no security event setup >> failed\n"); > > That seems like a double negative. > > Printing the rc value (or better yet, the string for it) > is always helpful too. Thanks Robert. Will fix. > > --- > Robert Elliott, HPE Persistent Memory > > _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
- Re: [PATCH 02/11] libnvdi... Mimi Zohar
- Re: [PATCH 02/11] lib... Dave Jiang
- Re: [PATCH 02/11... Mimi Zohar
- Re: [PATCH 0... Dave Jiang
- Re: [PATCH 02/11] libnvdimm/s... Dave Jiang
- Re: [PATCH 02/11] libnvdi... Mimi Zohar
- [PATCH 03/11] libnvdimm/security: add ... Dave Jiang
- [PATCH 04/11] libnvdimm/security: intr... Dave Jiang
- [PATCH 07/11] libnvdimm/security: add ... Dave Jiang
- RE: [PATCH 07/11] libnvdimm/secur... Elliott, Robert (Persistent Memory)
- Re: [PATCH 07/11] libnvdimm/s... Dave Jiang
- [PATCH 08/11] libnvdimm/security: add ... Dave Jiang
- [PATCH 11/11] acpi/nfit: prevent indis... Dave Jiang
- [PATCH 10/11] tools/testing/nvdimm: ad... Dave Jiang
- RE: [PATCH 10/11] tools/testing/n... Elliott, Robert (Persistent Memory)
- Re: [PATCH 10/11] tools/testi... Dave Jiang
- [PATCH 06/11] tools/testing/nvdimm: Ad... Dave Jiang
- [PATCH 09/11] acpi/nfit, libnvdimm/sec... Dave Jiang
- Re: [PATCH 09/11] acpi/nfit, libn... Dan Williams
- [PATCH 05/11] acpi/nfit, libnvdimm/sec... Dave Jiang