On Fri, Mar 22, 2019 at 10:56 AM Dexuan Cui <de...@microsoft.com> wrote: > > > From: Dan Williams <dan.j.willi...@intel.com> > > Sent: Thursday, March 21, 2019 11:12 PM > > To: Dexuan Cui <de...@microsoft.com> > > > > On Thu, Mar 21, 2019 at 11:03 PM Dexuan Cui <de...@microsoft.com> wrote: > > > > > > > From: Dan Williams <dan.j.willi...@intel.com> > > > > Sent: Thursday, March 21, 2019 10:37 PM > > > > > > > > No, I think you misunderstand. Hyper-V implements "function-1", > > > > "command-1" support can be emulated. The request is to translate the > > > > Hyper-V function-1 payload into the command-1 payload format. > > > > > > Then, yes, I think so. The first 2 patches of this patchset do the > > > translation: > > > > > > [ndctl,v2,1/4] libndctl: add support for NVDIMM_FAMILY_HYPERV's _DSM > > Function 1 > > > [ndctl,v2,2/4] libndctl: NVDIMM_FAMILY_HYPERV: > > add .smart_get_shutdown_count (Function 2) > > > > > > The problem is how to skip the checkings in ndctl/monitor.c: > > > filter_dimm() on > > Hyper-V. > > > If we return early in filter_dimm(), mfa->num_dimm will be zero, then > > monitor_event() > > > can't be called, and we have no chance to monitor the events and do the > > translation. > > > > I'd rather change ndctl_dimm_cmd_is_supported() to call back into a > > dimm-op so that the Hyper-V implementation can say "yes, I support > > (emulate) the necessary monitor commands". > > Hi Dan, > Then we need to add a new dimm-op monitor_supported()
Where would the monitor_supported() op be used? I would expect a cmd_is_supported() op? > and change > ndctl/lib/intel.c and ndctl/lib/hyper.c to implement the new dimm-op, and we > need to change the common code, i.e. ndctl_dimm_cmd_is_supported(), to use > this new dimm-op. This sounds good. > If this sounds reasonable to you and Verma, I'll try to make a patchset for > you > to review. Yes, just the question of what you meant the monitor_supported() op to perform. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
