Hi Anand, On Fri, Apr 25, 2008 at 1:11 AM, Gadiyar, Anand <[EMAIL PROTECTED]> wrote: > <snip> > > > diff --git a/include/asm-arm/arch-omap/dma.h > > b/include/asm-arm/arch-omap/dma.h > > index be0431e..270e158 100644 > > --- a/include/asm-arm/arch-omap/dma.h > > +++ b/include/asm-arm/arch-omap/dma.h > > @@ -273,6 +273,10 @@ > > #define OMAP24XX_DMA_MS 63 /* S_DMA_62 */ > > #define OMAP242X_DMA_EXT_DMAREQ5 64 /* S_DMA_63 */ > > #define OMAP243X_DMA_EXT_DMAREQ6 64 /* S_DMA_63 */ > > +#define OMAP34XX_DMA_MCBSP1_TX 31 /* S_DMA_30 */ > > +#define OMAP34XX_DMA_MCBSP1_RX 32 /* S_DMA_31 */ > > +#define OMAP34XX_DMA_MCBSP2_TX 33 /* S_DMA_32 */ > > +#define OMAP34XX_DMA_MCBSP2_RX 34 /* S_DMA_33 */ > > #define OMAP34XX_DMA_EXT_DMAREQ3 64 /* S_DMA_63 */ > > #define OMAP34XX_DMA_AES2_TX 65 /* S_DMA_64 */ > > #define OMAP34XX_DMA_AES2_RX 66 /* S_DMA_65 */ > > What's the point of this patch? Can't you use OMAP24XX_DMA_MCBSP* names?
Yes, OMAP24XX_DMA_MCBSP* can be used as they have same values. There is no big difference, but readability. That's the point of this patch. Defining names OMAP34XX_DMA_MCBSP* would let people to write more readable code when specifying things specific for OMAP34XX. > > > > diff --git a/include/asm-arm/arch-omap/irqs.h > > b/include/asm-arm/arch-omap/irqs.h > > index 15446fd..4e185a8 100644 > > --- a/include/asm-arm/arch-omap/irqs.h > > +++ b/include/asm-arm/arch-omap/irqs.h > > @@ -316,7 +316,11 @@ > > #define INT_34XX_USIM_IRQ 35 > > #define INT_34XX_WDT3_IRQ 36 > > #define INT_34XX_SPI4_IRQ 48 > > +#define INT_34XX_MCBSP1_IRQ_TX 59 > > +#define INT_34XX_MCBSP1_IRQ_RX 60 > > #define INT_34XX_I2C3_IRQ 61 > > +#define INT_34XX_MCBSP2_IRQ_TX 62 > > +#define INT_34XX_MCBSP2_IRQ_RX 63 > > #define INT_34XX_PBIAS_IRQ 75 > > #define INT_34XX_OHCI_IRQ 76 > > #define INT_34XX_EHCI_IRQ 77 > > Ditto with the IRQ lines? same here. > > @Tony, > It would be nice to give people some time to take a look at the patches > before they get pushed. > > Regards, > Anand > -- Eduardo Bezerra Valentin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
