From: "ext C.A, Subramaniam" <[email protected]>
Subject: RE: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo
Date: Mon, 14 Jun 2010 17:56:35 +0200
> Hi Ohad/Hiroshi,
>
> Good to see the new mailbox requirements. While we are at it can we add some
> more :)?
>
> * Make the mailbox as a generic driver.
> Meaning, users can request for a pair of mailbox rather than
> using a set of pre-defined ones. For eg: Instead of doing an
> omap_mbox_get("mailbox-1") we can have the user specify the mailbox
> pair that he needs ( omap_mbox_get(int tx_mbox, int rx_mbox) or
> similar API ). This also means that we remove the bulk of the data
> structures like omap2_mbox_1_priv and mbox_1_info and so
> on. Additional checks needs to be done so that consequtive requests
> to the driver does not re-configure the rx-tx pairs.
>
> Rationale:
> The pre-configured structures does make sense in case of DSP Bridge,
> since it is the only user of mailbox. However, for Syslink for
> example, (or for any other IPC or user of mailbox) it would be good
> for the user of the mailbox to request the pair (or just tx/rx) from
> user/kernel side.
Fair enough.
> * Provide debug support for the mailboxes (relevant for OMAP4)
> Since OMAP4 has support to read the RAW registers we might as
> well add an API for the user to read the status from RAW registers.
This could be debugfs.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
