On Wed, Sep 29, 2010 at 12:47 AM, Kevin Hilman
<khil...@deeprootsystems.com> wrote:

> I see what you're saying now.  The current #elif clause will *always* be
> true.
>
> You'll notice that all of this confusion would not have happened if the
> original changelog described the problem in detail, showing that that
> #elif clause will always be true, and especially not calling it a
> compliation fix.

I did not call it a compilation fix, I called it a _conditional_
compilation fix ;-).
The problem is not that the #elif clause ends up always being true.
The problem is that the preprocessor checks for the value of
CONFIG_ARCH_OMAP3 rather than the value of defined(CONFIG_ARCH_OMAP3).
Hence it emits warnings when CONFIG_ARCH_OMAP3 is not defined making
the #elif clause useless(which is there to check whether the macro is
defined or not).

>
> Please re-post with a better changelog and I will incoporate into the
> pm-cpufreq sub-branch of the PM branch.


Will do.

Thanks,
Silesh
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to