On Fri, 4 Feb 2011, Santosh Shilimkar wrote: > CPU0 and CPU1 clockdomain is at the offset of 0x18 from the LPRM base. > The header file has set it wrongly to 0x0. Offset 0x0 is for CPUx power > domain control register > > Fix the same. > > The autogen scripts is fixed thanks to Benoit Cousson > > Signed-off-by: Santosh Shilimkar <[email protected]> > Cc: Paul Walmsley <[email protected]> > Cc: Rajendra Nayak <[email protected]> > Cc: Benoit Cousson <[email protected]>
Will submit this one for -rc series, since this could result in writes to an incorrect register. Updated patch below. - Paul From: Santosh Shilimkar <[email protected]> Date: Fri, 4 Feb 2011 15:28:57 +0530 Subject: [PATCH] omap4: prcm: Fix the CPUx clockdomain offsets CPU0 and CPU1 clockdomain is at the offset of 0x18 from the LPRM base. The header file has set it wrongly to 0x0. Offset 0x0 is for CPUx power domain control register Fix the same. The autogen scripts is fixed thanks to Benoit Cousson With the old value, the clockdomain code would access the *_PWRSTCTRL.POWERSTATE field when it thought it was accessing the *_CLKSTCTRL.CLKTRCTRL field. In the worst case, this could cause system power management to behave incorrectly. Signed-off-by: Santosh Shilimkar <[email protected]> Cc: Paul Walmsley <[email protected]> Cc: Rajendra Nayak <[email protected]> Cc: Benoit Cousson <[email protected]> [[email protected]: added second paragraph to commit message] Signed-off-by: Paul Walmsley <[email protected]> --- arch/arm/mach-omap2/prcm_mpu44xx.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/prcm_mpu44xx.h b/arch/arm/mach-omap2/prcm_mpu44xx.h index 729a644..3300ff6 100644 --- a/arch/arm/mach-omap2/prcm_mpu44xx.h +++ b/arch/arm/mach-omap2/prcm_mpu44xx.h @@ -38,8 +38,8 @@ #define OMAP4430_PRCM_MPU_CPU1_INST 0x0800 /* PRCM_MPU clockdomain register offsets (from instance start) */ -#define OMAP4430_PRCM_MPU_CPU0_MPU_CDOFFS 0x0000 -#define OMAP4430_PRCM_MPU_CPU1_MPU_CDOFFS 0x0000 +#define OMAP4430_PRCM_MPU_CPU0_MPU_CDOFFS 0x0018 +#define OMAP4430_PRCM_MPU_CPU1_MPU_CDOFFS 0x0018 /* -- 1.7.2.3 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
