On 05/11/11 09:32, Tomi Valkeinen wrote:
> On Wed, 2011-05-11 at 10:28 +0530, Janorkar, Mayuresh wrote: > >>> +static void __init ldp_display_init(void) >>> +{ >>> + int r; >>> + >>> + struct gpio gpios[] = { >>> + {LCD_PANEL_RESET_GPIO, GPIOF_OUT_INIT_HIGH, "LCD RESET"}, >>> + {LCD_PANEL_QVGA_GPIO, GPIOF_OUT_INIT_HIGH, "LCD QVGA"}, >>> + {LCD_PANEL_ENABLE_GPIO, GPIOF_OUT_INIT_LOW, "LCD ENABLE"}, >>> + {LCD_PANEL_BACKLIGHT_GPIO, GPIOF_OUT_INIT_LOW, "LCD >>> BACKLIGHT"}, >>> + }; >>> + >>> + r = gpio_request_array(gpios, ARRAY_SIZE(gpios)); >>> + if (r) { >>> + pr_err("Cannot request LCD GPIOs, error %d\n", r); >>> + return; >>> + } >> If I test with this patch, this request is returning error. > Hmm. Well, the GPIOs are the same as in the old driver. However, the old > driver doesn't even seem to check if it manages to request the GPIOs, so > it may well be that it was failing also. > > Can you check from /sys/class/gpio/ if some of the GPIOs are already > allocated: 207, 199, 55, 56? > > The definition of two of those GPIOs look kinda funny to me: (15 + > OMAP_MAX_GPIO_LINES). I don't know what OMAP_MAX_GPIO_LINES means, but > it sure doesn't sound ok to have a GPIO number that is 15 over the > maximum =). > This means that some kind of gpio expander is used. I bet those are twl gpios (or may be some other discrete chip). If those are twl gpios then you need to provide the .setup callback in struct twl4030_gpio_platform_data which will request and setup those gpios. -- Regards, Igor. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html