There is no need to operate on all the banks every time the function is called.
Just operate on the current bank passed by the framework.

Signed-off-by: Tarun Kanti DebBarma <tarun.ka...@ti.com>
---
 drivers/gpio/gpio-omap.c |   53 +++++++++++++++++++++------------------------
 1 files changed, 25 insertions(+), 28 deletions(-)

diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index 3f1b992..47e5e20 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -1062,6 +1062,8 @@ static int __devinit omap_gpio_probe(struct 
platform_device *pdev)
                goto err_free;
        }
 
+       platform_set_drvdata(pdev, bank);
+
        pm_runtime_enable(bank->dev);
        pm_runtime_irq_safe(bank->dev);
        if (IS_ERR_VALUE(pm_runtime_get_sync(bank->dev) < 0)) {
@@ -1094,26 +1096,23 @@ err_exit:
 
 static int omap_gpio_suspend(struct device *dev)
 {
-       struct gpio_bank *bank;
-
-       pm_runtime_get_sync(dev);
+       struct platform_device *pdev = to_platform_device(dev);
+       struct gpio_bank *bank = platform_get_drvdata(pdev);
+       void __iomem *base = bank->base;
+       void __iomem *wake_status;
+       unsigned long flags;
 
-       list_for_each_entry(bank, &omap_gpio_list, node) {
-               void __iomem *base = bank->base;
-               void __iomem *wake_status;
-               unsigned long flags;
+       if (!bank->regs->wkup_status || !bank->suspend_wakeup)
+               return 0;
 
-               if (!bank->regs->wkup_status)
-                       return 0;
+       wake_status = bank->base + bank->regs->wkup_status;
 
-               wake_status = bank->base + bank->regs->wkup_status;
+       pm_runtime_get_sync(dev);
 
-               spin_lock_irqsave(&bank->lock, flags);
-               bank->saved_wakeup = __raw_readl(wake_status);
-               _gpio_rmw(base, bank->regs->wkup_status,
-                                       bank->suspend_wakeup, 1);
-               spin_unlock_irqrestore(&bank->lock, flags);
-       }
+       spin_lock_irqsave(&bank->lock, flags);
+       bank->saved_wakeup = __raw_readl(wake_status);
+       _gpio_rmw(base, bank->regs->wkup_status, bank->suspend_wakeup, 1);
+       spin_unlock_irqrestore(&bank->lock, flags);
 
        pm_runtime_put_sync(dev);
 
@@ -1122,21 +1121,19 @@ static int omap_gpio_suspend(struct device *dev)
 
 static int omap_gpio_resume(struct device *dev)
 {
-       struct gpio_bank *bank;
+       struct platform_device *pdev = to_platform_device(dev);
+       struct gpio_bank *bank = platform_get_drvdata(pdev);
+       void __iomem *base = bank->base;
+       unsigned long flags;
 
-       pm_runtime_get_sync(dev);
+       if (!bank->regs->wkup_status || !bank->saved_wakeup)
+               return 0;
 
-       list_for_each_entry(bank, &omap_gpio_list, node) {
-               void __iomem *base = bank->base;
-               unsigned long flags;
-
-               if (!bank->regs->wkup_status)
-                       return 0;
+       pm_runtime_get_sync(dev);
 
-               spin_lock_irqsave(&bank->lock, flags);
-               _gpio_rmw(base, bank->regs->wkup_status, bank->saved_wakeup, 1);
-               spin_unlock_irqrestore(&bank->lock, flags);
-       }
+       spin_lock_irqsave(&bank->lock, flags);
+       _gpio_rmw(base, bank->regs->wkup_status, bank->saved_wakeup, 1);
+       spin_unlock_irqrestore(&bank->lock, flags);
 
        pm_runtime_put_sync(dev);
 
-- 
1.6.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to