RE: [PATCH v4 13/20] gpio/omap: cleanup omap_gpio_mod_init function

[DebBarma, Tarun Kanti]

> -----Original Message-----
> From: Todd Poynor [mailto:toddpoy...@google.com]
> Sent: Thursday, July 14, 2011 11:26 AM
> To: DebBarma, Tarun Kanti
> Cc: linux-omap@vger.kernel.org; Hilman, Kevin; Shilimkar, Santosh;
> t...@atomide.com; linux-arm-ker...@lists.infradead.org; Varadarajan,
> Charulatha
> Subject: Re: [PATCH v4 13/20] gpio/omap: cleanup omap_gpio_mod_init
> function
> 
> On Wed, Jul 13, 2011 at 07:24:12PM +0530, Tarun Kanti DebBarma wrote:
> > With register offsets now defined for respective OMAP versions we can
> get rid
> > of cpu_class_* checks. This function now has common initialization code
> for
> > all OMAP versions. Initialization specific to OMAP16xx has been moved
> within
> > omap16xx_gpio_init().
> >
> ...
> > -   for (i = 0; i < ARRAY_SIZE(omap16xx_gpio_dev); i++)
> > +   for (i = 0; i < ARRAY_SIZE(omap16xx_gpio_dev); i++) {
> > +           pdev = omap16xx_gpio_dev[i];
> > +           pdata = pdev->dev.platform_data;
> > +           res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > +           base = ioremap(res->start, resource_size(res));
> 
> 
> Should check platform_get_resource and ioremap error returns.
Ok, thanks.
--
Tarun
> 
> > +
> > +           __raw_writel(0x0014, base + OMAP1610_GPIO_SYSCONFIG);
> 
> 
> Todd
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html