On Fri, 2011-12-09 at 12:23 -0800, Kevin Hilman wrote: > Hi Tero, > > Tero Kristo <t-kri...@ti.com> writes: > > > Changes compared to previous version: > > > > - merged most of the voltagedomain cleanup fixes to patch 2 > > - moved pmic latencies to omap_voltdm_pmic struct > > - renamed omap_lp_params to omap2_oscillator as it only contains > > osc info now > > - major changes to usecount support (patch 11+, needed for auto-ret) > > * added usecounts to voltagedomain / powerdomain > > * fixed usecount tracking so that the numbers are sane now > > * changed behavior of some usecounting sources that they do not > > update the counts (autoidle support) > > - added auto-ret / auto-off support, based on fixed usecounting > > * smartreflex disabled / enabled > > * auto-ret / auto-off enabled based on target state > > - some other minor tweaks I have probably forgotten to mention > > This series is looking really good. Thanks! > > One thing I'd like to see is a bit more comments. Particularily, the > new functions in the VC core need kerneldoc comments and verbose > descriptions. > > The differences in timing setups between retention and off are not > obvious when reading the code (and are easily forgotten). They also > equire a bit of TRM (re)reading to understand what's going on. Some > summary comments in the code, along with TRM references would be most > helpful so when coming back to this code in a few months or more, we can > easily remember what's going on (or at least where to look.) Thanks. >
Okay, I'll try to figure out more comments on next rev. This has never been too strong point in the code I write I guess. :) > > Tested on omap3 beagle: > > - voltages for vdd1 and vdd2 change when entering idle > > - both suspend and dynamic idle tested > > - tested that voltages reach target levels for both ret / off > > > > Tested on omap4 blaze with custom kernel > > - this requires a few additional patches missing from this set as > > omap4 PM support is still not merged > > MPUSS support is now queued (in Tony's tree), but CORE PM is still > missing. I can take a look at this part also, but CORE PM is needed for this set for testing purposes I believe, otherwise the auto-ret part does nothing and is rather impossible to test (not sure if mpu part scales without CORE PM, it might actually.) > > > - will post missing patches once possible from upstream point of view > > - voltages for vdd1 and vdd3 change when entering idle > > > > Applies on top of Kevin's for_3.2/voltage-cleanup branch. > > You can use mainline now as that branch is merged. Ah okay, good to know. > > Also, please Cc linux-arm-kernel on future versions of this series. Can do. -Tero -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
