On Mon, 17 Apr 2000 14:18:18 +0200, Luca Berra wrote:

> AFAIR there were a lot of places where add_partition is called with
> 0 as the last argument, should they all be changed ?

I haven't looked into all the other add_partition calls and I don't
know, if all partition-tables support types. I've just tested that for
OSF-partitions the fstype contains what is expected.

IMHO all add_partition calls where a partition-type is available
should be changed to make RAID autodetection working. But I'm not that
deep into kernel stuff to really decide that there are no
side-effects (so it's not my fault :-)).

I suspect that RAID autodetection is the only place where the
partition-type is really used. Otherwise this lack should have been
noticed before.


Ciao

Norbert



> 
> L.
> On Mon, Apr 17, 2000 at 12:29:39PM +0200, Norbert Eicker wrote:
> > So the following patch helped to make autodetection run on my system:
> > 
> > ----------------------------------------------------------------------
> > --- linux.orig/drivers/block/genhd.c        Thu Apr 13 13:28:25 2000
> > +++ linux/drivers/block/genhd.c     Mon Apr 17 12:12:19 2000
> > @@ -729,7 +729,7 @@
> >                 if (partition->p_size)
> >                         add_partition(hd, current_minor,
> >                                 first_sector+partition->p_offset,
> > -                               partition->p_size, 0);
> > +                               partition->p_size, partition->p_fstype);
> >                 current_minor++;
> >         }
> >         printk("\n");
> > ----------------------------------------------------------------------
> 
> -- 
> Luca Berra -- [EMAIL PROTECTED]
>     Communication Media & Services S.r.l.
> 

Reply via email to