On Thu, Jan 7, 2010 at 9:03 AM, Bart Van Assche <bart.vanass...@gmail.com> wrote: > On Thu, Jan 7, 2010 at 8:57 AM, Roland Dreier <rdre...@cisco.com> wrote: >> >> > It was only recently that I had the time to analyze this issue in >> > depth and that I added SRP_CRED_REQ support in SCST (checked in that >> > support about one week ago). Before SRP_CRED_REQ support was added in >> > SCST, the SRP initiator could not log the "Unhandled SRP opcode" >> > message because it did not receive any unhandled SRP opcodes. >> >> So it sounds like this is fixing something that was not the original >> bug? Because SCST wasn't sending SRP_CRED_REQ when the issue of the >> initiator hanging was originally seen, if I understand correctly. > > The patch I posted is really fixing the original bug. The problem was > that neither the SRP target nor the SRP initiator had support for > SRP_CRED_REQ. Support for SRP_CRED_REQ has to be added to both > software components in order to fix this bug.
However, I have to admit that the patch description should have described what happened more in detail. I'll address that in the second version of my patch. Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html