Hi Jim, [snip...]
On 20/Nov/09 21:15, Jim Schutt wrote:
diff --git a/opensm/opensm/osm_qos.c b/opensm/opensm/osm_qos.c index 08f9a60..f42c334 100644 --- a/opensm/opensm/osm_qos.c +++ b/opensm/opensm/osm_qos.c @@ -194,6 +194,7 @@ static ib_api_status_t sl2vl_update(osm_sm_t * sm, osm_port_t * p_port, { ib_api_status_t status; uint8_t i, num_ports; + struct osm_routing_engine *re = sm->p_subn->p_osm->routing_engine_used; osm_physp_t *p_physp; if (osm_node_get_type(osm_physp_get_node_ptr(p)) == IB_NODE_TYPE_SWITCH) { @@ -213,8 +214,24 @@ static ib_api_status_t sl2vl_update(osm_sm_t * sm, osm_port_t * p_port, } for (i = 0; i< num_ports; i++) { + ib_slvl_table_t routing_sl2vl; + const ib_slvl_table_t *port_sl2vl; + const ib_slvl_table_t *port_sl2vl_old; + + if (re->update_sl2vl) {
If routing failed, and no_fallback specified, OSM crashes here. The simple fix is, of course, just fixing the condition to "(re && re->update_sl2vl)", but I think that it would be better not to apply QoS configuration if unicast manager failed - just restart the sweep. -- Yevgeny -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html