OK. This will be in v3. On Wed, 2010-03-31 at 16:18 -0700, Roland Dreier wrote: > > +struct ib_dma_mapping_ops qib_dma_mapping_ops = { > > + qib_mapping_error, > > + qib_dma_map_single, > > + qib_dma_unmap_single, > > + qib_dma_map_page, > > + qib_dma_unmap_page, > > + qib_map_sg, > > + qib_unmap_sg, > > + qib_sg_dma_address, > > + qib_sg_dma_len, > > + qib_sync_single_for_cpu, > > + qib_sync_single_for_device, > > + qib_dma_alloc_coherent, > > + qib_dma_free_coherent > > +}; > > I think it would be better to use designated initializers (".xxx = yyy,") > here to avoid problems if this struct ever changes layout.
-- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html