So I'm looking at merging this, and I'm wondering about one thing. Seems like it's just a mistake but I want to make sure I understand properly:
> @@ -1078,6 +1079,7 @@ ssize_t ib_uverbs_create_qp(struct ib_uverbs_file > *file, > goto err_put; > } > > + attr.create_flags = 0; > attr.event_handler = ib_uverbs_qp_event_handler; This looks redundant, because this function already sets create_flags to 0 a few lines later. So I think this line is just a remnant from some other patch. But then ib_uverbs_create_xrc_rcv_qp() doesn't set create_flags before the call to device->create_xrc_rcv_qp() -- which maybe is OK, since that function is not going to look at create_flags right now, but for the future we should probably set it to 0, right? Also it's not 100% clear to me why the low-level driver needs a special create_xrc_rcv_qp method, rather than having uverbs just call create_qp with the right parameters. But I haven't looked throught carefully to see the differences between eg query_xrc_rcv_qp() vs query_qp() methods. - R. -- Roland Dreier <rola...@cisco.com> || For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/index.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
