Thanks. I accept this remark. We will try to address all the bothering issues regarding the patch set of RAW QP support and resubmit them linux-rdma. Since it won't work with Mellanox the patches will be only for Intel (nes) driver. When time comes and Mellanox cards can be tested for RAQ QO feature they will benefit from the common part.
--------------------------------------- Moni Shoua| +972-54-5567934 -----Original Message----- From: Roland Dreier [mailto:rdre...@cisco.com] Sent: Wednesday, June 23, 2010 8:32 PM To: Moni Shoua Cc: Aleksey Senin; Eli Cohen; e...@openfabrics.org; linux-rdma@vger.kernel.org; Tziporet Koren; Yiftah Shahar Subject: Re: [ewg] [PATCH v4] IB Core: RAW ETH support > There is no qp type IBV_QPT_RAW_ETY in user space (at least not in the definitions > coming with libibverbs). In fact, libibverbs that comes with OFED defines (in verbs.h) > a qp type called IBV_QPT_RAW_ETT which equals to 7. > The patch that is under discussion here adds a new qp type IB_QPT_RAW_ETH and equals it to 7 > to match the definition in user space. This indeed changes the value of IB_QPT_RAW_ETY to 8 > but I don't see who can be affected since > 1. No user space program that uses IB_QPT_RAW_ETY exists > 2. kernel is compiled as one piece of code. Why renumber the _ETY enum? Maybe it doesn't break anything serious but why risk it? -- Roland Dreier <rola...@cisco.com> || For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/index.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
