There is no choice but a module parameter since the msix initialization is done at driver load, and is only needed after testing reveals that the change is necessary.
I agree that there are a lot of module parameters. Some that don't allocate resources at load time could be "sys". I can re-issue the patch with module_param and change the identifier. The module parameters used throughout the code usually prepend a qib_ or and ib_qib_, and I was following precedent in the code. The only "no prepend" I see is the sdma_descq_cnt, which could change as well to use module_param. Mike > -----Original Message----- > From: rol...@purestorage.com [mailto:rol...@purestorage.com] On Behalf > Of Roland Dreier > Sent: Thursday, July 21, 2011 11:47 AM > To: Mike Marciniszyn > Cc: linux-rdma@vger.kernel.org > Subject: Re: [PATCH] IB/qib: defer hca error events to tasklet > > > +static ushort qib_krcvq01_no_msi; > > +module_param_named(krcvq01_no_msi, qib_krcvq01_no_msi, ushort, > S_IRUGO); > > +MODULE_PARM_DESC(krcvq01_no_msi, "No MSI for kctx < 2"); > > First, the obvious question: is there really no better way to handle > this > than to have yet another cryptically named module parameter for users > to try both ways? > > Second, why can't this just be module_param() (why is _named needed?)? This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
