On Thu, Jul 21, 2011 at 9:30 AM, Mike Marciniszyn <mike.marcinis...@qlogic.com> wrote: > There is no choice but a module parameter since the msix initialization is > done at driver load, and is only needed after testing reveals that the change > is necessary. > > I agree that there are a lot of module parameters. Some that don't allocate > resources at load time could be "sys". > > I can re-issue the patch with module_param and change the identifier. > > The module parameters used throughout the code usually prepend a qib_ or and > ib_qib_, and I was following precedent in the code. > > The only "no prepend" I see is the sdma_descq_cnt, which could change as well > to use module_param.
I looked over the code and I think it makes sense to match the existing practice with module_param. Longer term cleaning that up might be worthwhile, but even better would be to get rid of the need for so many knobs for users to adjust. In any case I went ahead and applied this, since I don't think it's worth quibbling over. - R. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
