Hi

Le 10.10.2013 11:01, Or Gerlitz a écrit :
On 10/10/2013 11:32, Yann Droneaud wrote:
Le 10.10.2013 10:02, Or Gerlitz a écrit :
On 10/10/2013 00:12, Yann Droneaud wrote:
I've suggested reverting temporarily commit 22878db, 436f2ad, 400dbc9
for v3.12 in a previous message [1]. This proposition doesn't sound
acceptable for Or.

So I continue to improve them to be in a better shape for v3.12.

Yan, we are 3-4 days before rc5 and as such renaming/beautifying
things or removing checks for negative values
against unsigned variables et al cleanups are not acceptable. You need
to re-arrange the series such that ONLY the fixes
to the user/kernel API are targeted to 3.12 and appear as the first
2-3 patches, the rest will go to 3.13 subject to review.


It does not only "beautifying" the code: it actually fix it.

IB/core: Rename 'flow' structs to match other uverbs structs

Public API, exposed to userspace

IB/core: Makes uverbs flow structure using names more similar to verbs ones

Public API, exposed to userspace

IB/core: Remove checks for negative values in create_flow uverbs


This one could go for v3.13. (But probably to discard if Matan's one is applied
first, see below).

You must agree that these three patches can go to 3.13 -- also, if there are other small fixes which do not touch the user/kernel API they can go to 3.13
too and subject to review into -stable

What you need to prepare for 3.12 are fixes that relate to user/kernel API
and are not fixed in the patch Matan sent on Sep 22nd
https://patchwork.kernel.org/patch/2924341
and relative to that patch


This patch could go for 3.13 too: it's not altering (fixing) the public API.

In the meantime, I've sent a patch that will lower the urge to fix for v3.12,
and reduce the size of the merge request to be proposed to Linus.

Regards.

--
Yann Droneaud
OPTEYA

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to