Ack.  That's a bug.  Will fix.

Upinder

On Dec 10, 2013, at 1:14 PM, Roland Dreier <rol...@purestorage.com> wrote:

> On Mon, Sep 9, 2013 at 8:38 PM, Upinder Malhi (umalhi) <uma...@cisco.com> 
> wrote:
>> +/*TODO: Future - usnic_modify_qp needs to pass in generic filters */
>> +struct usnic_ib_create_qp_resp {
>> +       u32                             vfid;
>> +       u32                             qp_grp_id;
>> +       u64                             bar_bus_addr;
>> +       u32                             bar_len;
>> +/*
>> + * WQ, RQ, CQ are explicity specified bc exposing a generic resources 
>> inteface
>> + * expands the scope of ABI to many files.
>> + */
>> +       u32                             wq_cnt;
>> +       u32                             rq_cnt;
>> +       u32                             cq_cnt;
>> +       u32                             wq_idx[USNIC_QP_GRP_MAX_WQS];
>> +       u32                             rq_idx[USNIC_QP_GRP_MAX_RQS];
>> +       u32                             cq_idx[USNIC_QP_GRP_MAX_CQS];
>> +       u32                             transport;
> 
> Unless I'm misreading this, the u64 reserved field will have different
> alignment on platforms that align u64 to 4 bytes (eg 32-bit x86) and
> to 8 bytes (eg 64-bit x86) which means you'll have problems running
> 32-bit userspace on a 64-bit kernel.
> 
>> +       u64                             reserved;
>> +};

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to