On 04/13/2015 09:27 PM, Jason Gunthorpe wrote:
> On Mon, Apr 13, 2015 at 02:25:16PM +0200, Michael Wang wrote:
>> dev_list = kmalloc(sizeof *dev_list, GFP_KERNEL);
>> if (!dev_list)
>> @@ -1673,13 +1671,19 @@ static void ipoib_add_one(struct ib_device *device)
>> }
>>
>> for (p = s; p <= e; ++p) {
>> - if (rdma_port_get_link_layer(device, p) !=
>> IB_LINK_LAYER_INFINIBAND)
>> + if (!rdma_tech_ib(device, p))
>> continue;
>> dev = ipoib_add_port("ib%d", device, p);
>> if (!IS_ERR(dev)) {
>> priv = netdev_priv(dev);
>> list_add_tail(&priv->list, dev_list);
>> }
>> + count++;
>> + }
>> +
>> + if (!count) {
>> + kfree(dev_list);
>> + return;
>> }
>
> This doesn't quite look right, it should be 'goto error1'
>
> But then I read 'goto error1' and it doesn't look like it can handle
> cm_dev->port being NULL, so more fixing is needed.
Nice catch ;-) I guess the 'count++' should be inside 'if (!IS_ERR(dev))' after
link the node.
Regards,
Michael Wang
>
> Ditto for cm_remove_one
>
> Should audit all uses of cm_dev->port[] to make sure they can all
> handle NULL.
>
> Jason
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
