On Tue, May 19, 2015 at 3:24 PM, Wan, Kaike <kaike....@intel.com> wrote: >> On 5/18/2015 10:00 PM, kaike....@intel.com wrote:
>> > --- a/drivers/infiniband/core/sa_query.c >> > +++ b/drivers/infiniband/core/sa_query.c >> > @@ -45,12 +45,22 @@ >> what's actually the role of the module param? why it belongs here? is that >> really unavoidable to have it? > It's nice to provide the capability for the user to adjust the netlink > timeout based his/her fabric setup. NO, adding module params should be really your last resort when everything else wouldn't work, definitely not the case here, remove it. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
