> >>> +/* Local Service Reversible attribute */ struct > >>> +rdma_nla_ls_reversible { > >>> + __u32 reversible; > >>> +}; > >> > >> Isn't __u8 sufficient for reversible ? > > Certainly enough. However, reversible is __u32 in struct > ib_user_path_rec and int in struct ib_sa_path_rec. > > OK; I hadn't double checked there. So it's "inherited" from those > reversible definitions.
I don't think we need to adhere to the sizes defined in other structures. I agree with Hal's original comment. A __u8 here seems sufficient, unless we want to introduce some bit fields. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html