> > cap_is_switch_smi would be a nice refinement to let us drop nodetype.
> 
> Exactly, we need a bit added to the immutable data bits, and a new cap_
> helper, and then nodetype is ready to be retired.  Add a bit, drop a
> u8 ;-)

I agree that the node type enum isn't particularly useful and should be 
retired.  In fact, I don't see where RDMA_NODE_IB_SWITCH is used by any 
upstream device.  So I don't think there's any obligation to keep it.  But even 
if we do, I'm not sure this is the correct approach.  I don't know this for a 
fact, but it seems more likely that someone would embed Linux on an IB switch 
than they would plug an IB switch into a Linux based system.  The code is 
designed around the latter.  Making this a system wide setting might simplify 
the code and optimize the code paths.

- Sean
N�����r��y����b�X��ǧv�^�)޺{.n�+����{��ٚ�{ay�ʇڙ�,j��f���h���z��w���
���j:+v���w�j�m��������zZ+�����ݢj"��!�i

Reply via email to