On 6/11/2015 5:00 PM, Hefty, Sean wrote:
>>> cap_is_switch_smi would be a nice refinement to let us drop nodetype.
>>
>> Exactly, we need a bit added to the immutable data bits, and a new cap_
>> helper, and then nodetype is ready to be retired. Add a bit, drop a
>> u8 ;-)
>
> I agree that the node type enum isn't particularly useful and should be
> retired.
Are you referring to kernel space or user space or both ?
> In fact, I don't see where RDMA_NODE_IB_SWITCH is used by any upstream
> device.
While not upstream, there are at least 2 vendors with one or more switch
device drivers using the upstream stack.
> So I don't think there's any obligation to keep it.
In kernel space, we can get rid of it but it's exposed by verbs and
currently relied upon in user space in a number of places.
There's one kernel place that needs more than just cap_is_switch_smi().
> But even if we do, I'm not sure this is the correct approach. I don't know
> this for a fact,
> but it seems more likely that someone would embed Linux on an IB switch than
> they would plug an IB switch
> into a Linux based system. The code is designed around the latter. Making
> this a system wide setting might simplify the code and optimize the code
> paths.
I think we need to discuss how user space would be addressed.
-- Hal
> - Sean
> N�����r��y���b�X��ǧv�^�){.n�+����{��ٚ�{ay� ʇڙ�,j��f���h���z� �w���
> ���j:+v���w�j�m��������zZ+��ݢj"��!tml=
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
