> -----Original Message----- > From: Haggai Eran [mailto:hagg...@mellanox.com] > Sent: Tuesday, June 30, 2015 2:25 AM > To: Steve Wise; dledf...@redhat.com > Cc: r...@mellanox.com; sa...@mellanox.com; linux-rdma@vger.kernel.org; > jguntho...@obsidianresearch.com; infinip...@intel.com; > e...@mellanox.com; ogerl...@mellanox.com; sean.he...@intel.com > Subject: Re: [PATCH V2 3/5] RDMA/core: transport-independent access flags > > On 30/06/2015 00:36, Steve Wise wrote: > > /** > > + * rdma_mr_roles - possible roles an RDMA MR will be used for > > + * > > + * This allows a transport independent RDMA application to > > + * create MRs that are usable for all the desired roles w/o > > + * having to understand which access rights are needed. > > + */ > > +enum { > > + > > + /* lkey used in a ib_recv_wr sge */ > > + RDMA_MRR_RECV = 1, > > + > > + /* lkey used for a IB_WR_SEND in the ib_send_wr sge */ > > + RDMA_MRR_SEND = (1<<1), > Perhaps you should mention that this covers all the IB_WR_SEND* opcodes > (SEND_WITH_IMM and SEND_WITH_INV). READ, WRITE and ATOMICs also have > several variants. >
Agreed. > > + > > + /* rkey used for a IB_WR_RDMA_READ in ib_send_wr wr.rdma.rkey */ > > + RDMA_MRR_READ_SOURCE = (1<<2), > > + > > + /* lkey used for a IB_WR_RDMA_READ in the ib_send_wr sge */ > > + RDMA_MRR_READ_DEST = (1<<3), > > + > > + /* lkey used for a IB_WR_RDMA_WRITE in the ib_send_wr sge */ > > + RDMA_MRR_WRITE_SOURCE = (1<<4), > > + > > + /* rkey used for a IB_WR_RDMA_WRITE in ib_send_wr wr.rdma.rkey */ > > + RDMA_MRR_WRITE_DEST = (1<<5), > > + > > + /* > > + * rkey used for a IB_WR_ATOMIC/MASKED_ATOMIC in ib_send_wr > > + * wr.atomic.rkey > > + */ > > + RDMA_MRR_ATOMIC = (1<<6), > What about using as an lkey in an IB_WR_ATOMIC/MASKED_ATOMIC in the > ib_send_wr sge? Do you want that to be covered by RDMA_MRR_SEND? > Ah yes. Perhaps we need ATOMIC_SOURCE and ATOMIC_DEST. I wouldn't include it in the SEND. > > + > > + /* MR used for a IB_WR_MW_BIND in ib_send_wr wr.bind_mw.bind_info.mr */ > > + RDMA_MRR_MW_BIND = (1<<7), > > +}; -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
