On 7/22/2015 9:02 PM, Jason Gunthorpe wrote:
On Wed, Jul 22, 2015 at 09:55:28AM +0300, Sagi Grimberg wrote:
+/**
+ * ib_map_mr_sg() - Populates MR with a dma mapped SG list
+ * @mr: memory region
+ * @sg: dma mapped scatterlist
+ * @sg_nents: number of entries in sg
+ * @access: access permissions
Again, related to my prior comments, please have two of these:
ib_map_mr_sg_rkey()
ib_map_mr_sg_lkey()
So we force ULPs to think about what they are doing properly, and we
get a chance to actually force lkey to be local use only for IB.
The lkey/rkey decision is passed in the fastreg post_send().
ib_map_mr_sg is just a mapping API, not the registration itself.
+static inline void
+ib_set_fastreg_wr(struct ib_mr *mr,
+ u32 key,
The key should come from MR. Once the above is split then it is
obvious which key to use.
IMO, it's obvious as it is. I don't see why should anyone get it
wrong.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html