On Thu, Sep 28, 2023 at 08:58:58AM -0700, Tanmay Shah wrote:
> Add properties as per new bindings in zynqmp remoteproc node
> to represent TCM address and size. This patch configures
> RPU in split mode and adds TCM information accordingly.
>

Why is this changed from lockstep to split mode?  What about all the people out
there that are expecting a lockstep mode?

> Signed-off-by: Tanmay Shah <[email protected]>
> ---
>  arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 28 ++++++++++++++++++++------
>  1 file changed, 22 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi 
> b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> index b61fc99cd911..01e12894c88e 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> @@ -247,19 +247,35 @@ fpga_full: fpga-full {
>               ranges;
>       };
>  
> -     remoteproc {
> +     remoteproc@ffe00000 {
>               compatible = "xlnx,zynqmp-r5fss";
> -             xlnx,cluster-mode = <1>;
> +             xlnx,cluster-mode = <0>;
>  
> -             r5f-0 {
> +             #address-cells = <2>;
> +             #size-cells = <2>;
> +
> +             ranges = <0x0 0x0 0x0 0xffe00000 0x0 0x10000>,
> +                      <0x0 0x20000 0x0 0xffe20000 0x0 0x10000>,
> +                      <0x1 0x0 0x0 0xffe90000 0x0 0x10000>,
> +                      <0x1 0x20000 0x0 0xffeb0000 0x0 0x10000>;
> +
> +             r5f@0 {
>                       compatible = "xlnx,zynqmp-r5f";
> -                     power-domains = <&zynqmp_firmware PD_RPU_0>;
> +                     reg = <0x0 0x0 0x0 0x10000>, <0x0 0x20000 0x0 0x10000>;
> +                     reg-names = "atcm", "btcm";
> +                     power-domains = <&zynqmp_firmware PD_RPU_0>,
> +                                     <&zynqmp_firmware PD_R5_0_ATCM>,
> +                                     <&zynqmp_firmware PD_R5_0_BTCM>;
>                       memory-region = <&rproc_0_fw_image>;
>               };
>  
> -             r5f-1 {
> +             r5f@1 {
>                       compatible = "xlnx,zynqmp-r5f";
> -                     power-domains = <&zynqmp_firmware PD_RPU_1>;
> +                     reg = <0x1 0x0 0x0 0x10000>, <0x1 0x20000 0x0 0x10000>;
> +                     reg-names = "atcm", "btcm";
> +                     power-domains = <&zynqmp_firmware PD_RPU_1>,
> +                                     <&zynqmp_firmware PD_R5_1_ATCM>,
> +                                     <&zynqmp_firmware PD_R5_1_BTCM>;
>                       memory-region = <&rproc_1_fw_image>;
>               };
>       };
> -- 
> 2.25.1
> 

Reply via email to