Hi Ramesh, On Thu, Feb 25, 2016 at 5:48 PM, Ramesh Shanmugasundaram <ramesh.shanmugasunda...@bp.renesas.com> wrote: > This patch adds CANFD[0-1] pinmux support to r8a7795 SoC. > > Signed-off-by: Ramesh Shanmugasundaram > <ramesh.shanmugasunda...@bp.renesas.com>
Sorry, I spoke too soon. While the pin data is correct, I noticed the following while applying: > --- a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c > +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c > @@ -2940,6 +2940,36 @@ static const unsigned int can1_data_pins[] = { > static const unsigned int can1_data_mux[] = { > CAN1_TX_MARK, CAN1_RX_MARK, > }; > + > +/* - RCAN FD --------------------------------------------------------------- > */ Please use "CAN" instead of "RCAN", and insert in alphabetical order. > +static const unsigned int canfd0_data_a_pins[] = { > @@ -3362,6 +3392,9 @@ static const struct sh_pfc_pin_group pinmux_groups[] = { > SH_PFC_PIN_GROUP(can0_data_a), > SH_PFC_PIN_GROUP(can0_data_b), > SH_PFC_PIN_GROUP(can1_data), > + SH_PFC_PIN_GROUP(canfd0_data_a), > + SH_PFC_PIN_GROUP(canfd0_data_b), > + SH_PFC_PIN_GROUP(canfd1_data), > SH_PFC_PIN_GROUP(can_clk), Please insert in alphabetical order. > @@ -3686,6 +3719,15 @@ static const char * const can1_groups[] = { > "can1_data", > }; > > +static const char * const canfd0_groups[] = { > + "canfd0_data_a", > + "canfd0_data_b", > +}; > + > +static const char * const canfd1_groups[] = { > + "canfd1_data", > +}; Please insert in alphabetical order. > + > static const char * const can_clk_groups[] = { > "can_clk", > }; > @@ -3721,6 +3763,8 @@ static const struct sh_pfc_function pinmux_functions[] > = { > SH_PFC_FUNCTION(ssi), > SH_PFC_FUNCTION(can0), > SH_PFC_FUNCTION(can1), > + SH_PFC_FUNCTION(canfd0), > + SH_PFC_FUNCTION(canfd1), > SH_PFC_FUNCTION(can_clk), Please insert in alphabetical order. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds