On Mon, Jun 17, 2019 at 10:27:03AM +0200, Simon Horman wrote:
> + Niklas
> 
> On Wed, Jun 12, 2019 at 03:20:51PM +0100, Biju Das wrote:
> > This series aims to enhance thermal support by adding cpu-map,
> > capacity-dmips-mhz,thermal zone to support IPA and also adding 
> > dynamic power coefficients.
> > 
> > For CPU capacity-dmips-mhz calculation
> > -------------------------------------
> > dhrystone cross complied using the command [1].
> > [1] $CC -O3 -DTIME -fno-inline -fno-builtin-printf -Wno-implicit 
> > -march=armv8-a dhry_1.c dhry_2.c -o exe-dry
> > 
> > dhrystone is executed(with a loop value of 80000000) and took the average 
> > value for 5 iterations
> > of CA57 and CA53.
> > 
> > IPA testing
> > ----------
> > 
> > 1)Enable THERMAL_WRITABLE_TRIPS and THERMAL_STATISTICS in kernel
> > 
> > 2) Check the current  temperature(36.5 C) and check the cooling stats on 
> > device0 and device 1
> > 
> > Execute the below applications on an ssh session
> > 
> > 3) while true; do touch pic-`date +%s`.jpg;done &  will give almost 0.5 C 
> > jump on each instance
> > 
> > 4) Executing dhrystone will give 3-4 C jump(runs through the benchmark: 
> > 800000000)
> > 
> > 5) Now the current temperature is around 46.0 C and there is no change in 
> > cooling stats on device0 and device 1
> > 
> > 6) Now change the passive trip temperature to 42 C, At this time CPUFreq 
> > started kicking in trying to limit the temperature, which you can see 
> > through the cooling stats on device0 and device1. You can see the system 
> > trying to maintain the temperature around 42 C.
> > 
> > 7)  Without changing the load, Now change  the passive trip temperature to 
> > 100 C, the temperature rises back to 46 C again.
> 
> ...
> 
> Thanks,
> 
> This looks fine to me but I will wait to see if there are other reviews
> before applying.

Thanks again,

I have applied this series for inclusion in v5.3.

Reply via email to