James:
This patch (as541) adds a missing check for an error return code from
scsi_sysfs_add_sdev. This resolves entry #4863 in the OSDL bugzilla.
Although in that bug report the failure occurred because of a confusion
over scanning vs. rescanning, in general add_sdev can fail for a number of
reasons (the simplest being insufficient memory) and the caller should
cope properly.
Alan Stern
Signed-off-by: Alan Stern <[EMAIL PROTECTED]>
Index: 2.6.13-rc2/drivers/scsi/scsi_scan.c
===================================================================
--- 2.6.13-rc2.orig/drivers/scsi/scsi_scan.c
+++ 2.6.13-rc2/drivers/scsi/scsi_scan.c
@@ -756,7 +756,8 @@ static int scsi_add_lun(struct scsi_devi
* register it and tell the rest of the kernel
* about it.
*/
- scsi_sysfs_add_sdev(sdev);
+ if (scsi_sysfs_add_sdev(sdev) != 0)
+ return SCSI_SCAN_NO_RESPONSE;
return SCSI_SCAN_LUN_PRESENT;
}
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
