libata already uses an internal buffer, so we should be using __scsi_print_command() here.
Cc: Tejun Heo <t...@kernel.org> Cc: linux-...@vger.kernel.org Cc: LKML <linux-ker...@vger.kernel.org> Signed-off-by: Hannes Reinecke <h...@suse.de> --- drivers/ata/libata-eh.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c index dad83df..74c5652 100644 --- a/drivers/ata/libata-eh.c +++ b/drivers/ata/libata-eh.c @@ -2509,15 +2509,11 @@ static void ata_eh_link_report(struct ata_link *link) if (ata_is_atapi(qc->tf.protocol)) { if (qc->scsicmd) - scsi_print_command(qc->scsicmd); + __scsi_print_command(cdb_buf, sizeof(cdb_buf), + qc->scsicmd->cmnd); else - snprintf(cdb_buf, sizeof(cdb_buf), - "cdb %02x %02x %02x %02x %02x %02x %02x %02x " - "%02x %02x %02x %02x %02x %02x %02x %02x\n ", - cdb[0], cdb[1], cdb[2], cdb[3], - cdb[4], cdb[5], cdb[6], cdb[7], - cdb[8], cdb[9], cdb[10], cdb[11], - cdb[12], cdb[13], cdb[14], cdb[15]); + __scsi_print_command(cdb_buf, sizeof(cdb_buf), + (unsigned char *)cdb); } else { const char *descr = ata_get_cmd_descript(cmd->command); if (descr) -- 1.8.5.2 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html