On Thu, Nov 10, 2016 at 07:48:20AM +0100, Hannes Reinecke wrote: > What I find quite irritating is that we still have to call > irq_set_affinity_hint(irq, NULL) when freeing up interrupts. > Can't we roll that into the call to free_irq() ?
If you do call it that's irritation, because you should not call irq_set_affinity_hint ever if you are using PCI_IRQ_AFFINITY, and the above branch doesn't call it. > And you _do_ have to setup a cpumap within the driver :-) For the non-mq case, yes - but only to keep the functionality as-is. We shouldn't add anything like this to a new driver. > Anyway, remainder looks pretty close to what I've written up. > Feel free to add my 'Reviewed-by:' to it. I'm mostly looking for someone who has the hardware to actually test it, though. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
