> +typedef struct {
> +     struct list_head        list;
> +     u8              iocb[64];       /* imm_ntfy_from_isp */

Please keep it as struct imm_ntfy_from_isp so that all the crazy
casts in the new code can be removed.

> +     qlt_plogi_ack_t* plogi_link[QLT_PLOGI_LINK_MAX];

        qlt_plogi_ack_t *plogi_link[QLT_PLOGI_LINK_MAX];

> +             if (con)
> +             {

                if (con) {

>       spin_lock_irqsave(&ha->tgt.sess_lock, flags);
> +     ha->tgt.tgt_ops->put_sess(sess);
>       spin_unlock_irqrestore(&ha->tgt.sess_lock, flags);

This pattern happens a lot and should probably be factored into a
helper.

> +     struct fc_port  *sess = container_of(kref,
> +         struct fc_port, sess_kref);

This can fit into a single line:

        struct fc_port *sess = container_of(kref, struct fc_port, sess_kref);

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to