Hello Hans, On Sun, Jan 5, 2014 at 12:48 AM, Hans de Goede <[email protected]> wrote: > Hi Arokux et al, > > So I've been working on cleaning up the sunxi-ehci support by > writing a separate phy driver for the usbphy part of the SoC. > > This is turning out quite nicely, for those interested you > can find my wip here: > > Note only tested on sun7i sofar, and the sun4i / sun5i dt > bits aren't updated yet. > > The bulk of the work is in these 2 commits: > https://github.com/jwrdegoede/linux-sunxi/commit/4655dd01936f42d8a75da08a00af439e0a34eaf7 > https://github.com/jwrdegoede/linux-sunxi/commit/bcb674859d015ff9e082829dbd5cf239b8b53d4a
Nice work! Have you maybe forgotten to commit changes to the corresponding dtsi files? I'm particularly interested in how do you bind reset bits. In addition I've seen you did this https://github.com/jwrdegoede/linux-sunxi/commit/e2d95f5509f799c4264153ae8dd9d51eb2baba42 Are you maybe trying to use reset driver written by Maxime to handle sunxi reset bits? There was a try to do it like so and the above rename was done by Maxime (and I had the code that has used it). Later howerever he has reverted this rename since it was decided to use the feature of the clk framework which can handle reset bits. Here is an example drivers/usb/phy/phy-msm-usb.c +309 I was not following Maxime's work closely lately, so can you please clarify this? Best, Arokux > Note there is no more addition of an ehci-sunxi.c driver, instead > the new stuff is generic enough that a simply extension to > ehci-platform.c is enough to get things to work nicely. > > Adding ohci support also should be quite easy now, I'll take a > shot at that tomorrow. > > Regards, > > Hans -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
