Hi,
On 01/05/2014 11:56 AM, Arokux X wrote:
Hello Hans,
On Sun, Jan 5, 2014 at 12:48 AM, Hans de Goede <hdego...@redhat.com> wrote:
Hi Arokux et al,
So I've been working on cleaning up the sunxi-ehci support by
writing a separate phy driver for the usbphy part of the SoC.
This is turning out quite nicely, for those interested you
can find my wip here:
Note only tested on sun7i sofar, and the sun4i / sun5i dt
bits aren't updated yet.
The bulk of the work is in these 2 commits:
https://github.com/jwrdegoede/linux-sunxi/commit/4655dd01936f42d8a75da08a00af439e0a34eaf7
https://github.com/jwrdegoede/linux-sunxi/commit/bcb674859d015ff9e082829dbd5cf239b8b53d4a
Nice work!
Thanks.
Have you maybe forgotten to commit changes to the corresponding dtsi
files?
Yes and no, as mentioned I've only updated and tested sun7i dts(i) atm.
I'm particularly interested in how do you bind reset bits.
I'm still using your "hack" which uses Maxime's reset driver, I know this
is wrong. I thought you already had a fix for this, which is why I've been
asking you to push your latest work. If you don't have a fix yet, I can
look into one. I've not touched this part yet because I thought you already
have a fix.
In addition I've seen you did this
https://github.com/jwrdegoede/linux-sunxi/commit/e2d95f5509f799c4264153ae8dd9d51eb2baba42
Are you maybe trying to use reset driver written by Maxime to handle
sunxi reset bits?
Yes, and as said I know this is wrong, but it works for now, for upstream
this need to be properly fixed.
There was a try to do it like so and the above
rename was done by Maxime (and I had the code that has used it). Later
howerever he has reverted this rename since it was decided to use the
feature of the clk framework which can handle reset bits. Here is an
example
drivers/usb/phy/phy-msm-usb.c +309
Ah, examples are always good. So if you don't have a fix for this yet
let me know and I'll go and write one based on this.
I was not following Maxime's work closely lately, so can you please
clarify this?
See above.
Regards,
Hans
--
You received this message because you are subscribed to the Google Groups
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
