On Fri, Apr 11, 2014 at 1:25 PM, Arnd Bergmann <a...@arndb.de> wrote: > On Friday 11 April 2014 11:38:05 Carlo Caione wrote: >> +#define AXP20X_IRQ(_irq, _off, _mask) \ >> + [AXP20X_IRQ_##_irq] = { .reg_offset = (_off), .mask = BIT(_mask) } >> + >> +static const struct regmap_irq axp20x_regmap_irqs[] = { >> + AXP20X_IRQ(ACIN_OVER_V, 0, 7), >> + AXP20X_IRQ(ACIN_PLUGIN, 0, 6), >> + AXP20X_IRQ(ACIN_REMOVAL, 0, 5), >> + AXP20X_IRQ(VBUS_OVER_V, 0, 4), >> + AXP20X_IRQ(VBUS_PLUGIN, 0, 3), >> + AXP20X_IRQ(VBUS_REMOVAL, 0, 2), >> + AXP20X_IRQ(VBUS_V_LOW, 0, 1), >> + AXP20X_IRQ(BATT_PLUGIN, 1, 7), >> + AXP20X_IRQ(BATT_REMOVAL, 1, 6), >> + AXP20X_IRQ(BATT_ENT_ACT_MODE, 1, 5), >> + AXP20X_IRQ(BATT_EXIT_ACT_MODE, 1, 4), >> + AXP20X_IRQ(CHARG, 1, 3), >> + AXP20X_IRQ(CHARG_DONE, 1, 2), >> + AXP20X_IRQ(BATT_TEMP_HIGH, 1, 1), > > Why do you have to enumerate the interrupts here? Can't you just > put all the numbers into the DT nodes of the devices using them? > > In general, I would say that the mfd driver should not care about > what is connected to it.
I need this for the regmap irq chip (to be used in regmap_add_irq_chip()). I'm not sure if you are suggesting to get rid of the irq chip. br, -- Carlo Caione -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.