On 04/15/2014 12:41 AM, Chen-Yu Tsai wrote:
Patch description?
> diff --git a/Documentation/devicetree/bindings/rfkill/rfkill-gpio.txt
> b/Documentation/devicetree/bindings/rfkill/rfkill-gpio.txt
> +Required properties:
> +- gpios : At most two GPIO phandles
> +- gpio-names : Shall be "reset" or "shutdown", matching gpios.
> + If both are provided, the "reset" GPIO is toggled first.
As Maxime mentioned, this is an unusual way of defining GPIOs. If this
new way is acceptable, then I'd suggest more precise wording, e.g.:
- gpios: Must contain an entry for each entry in gpio-names.
See ../gpio/gpio.txt for details.
- gpio-names: May contain any or all of the following entries:
- reset
- shutdown
> +- rfkill-type : Type of RFKILL device: 1 for WiFi, 2 for BlueTooth,
> etc.
> + See include/uapi/linux/rfkill.h for all valid values
It would be nice if include/dt-bindings/rfkill-gpio.h existed and
contained e.g.:
#define RFKILL_TYPE_BLUETOOTH 2
So that:
> +Example:
> +
> + rfkill_bt {
...
> + rfkill-type = <2>;
Could be written as:
rfkill-type = <RFKILL_TYPE_BLUETOOTH>;
--
You received this message because you are subscribed to the Google Groups
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
