> >> > >> I am going away for few days for not being too noisy. > > > > There's nothing wrong with being too noisy. > > Absolutely, thank you for working on this. > +1 on that. I was thinking about contacting Wingrime about taking on this driver as I thought it would be quite a nice one to start mainlining effort with. I've got LIRC set up on my 3.4 setup so if required I can help with ack-ing this on a A10 setup.
> > > > If you have the time, please keep testing and working on this and > > reporting what you find. > > > > Oh, and a couple of administrative points: > > 1. Seriously think about splitting this up. It won't make it upstream > > without doing that and collecting approval from all the relevant > > subsystems. - that said, this can wait until you've dealt with the > > timer issues and added support (where relevant) for other boards. > > 2. You need to work a bit more on the non-code parts of your patch > > submissions, you need a short description at the very least. > > 3. You should start versioning your patches. > > 4. You also need to keep an eye open for any extra lines you add. > > 5. It's better to resubmit entire patches instead of small incremental > > patches on top of existing ones. > > > > Your next patch submission should look something like this: (Assuming > > what I've said is accurate) > > > > Subject: [PATCH v2] sunxi: Add support for consumer infrared devices > > > > Body: > > > > This patch introduces Consumer IR(CIR) support for sunxi boards. > > > > This is based on Alex Allss' work based on the original driver > > supplied by Allwinner. > > > > Signed-off-by: Alexander..... > > CC: wingrime@.... > > +1 on all of the above. > Could you also run this through checkpatch to ensure clean delivery. I've noticed a few 'magic numbers' in the patch, could you convert these to relevant defines?, it shows a greater understanding of the hardware. > > Since this is based on wingrime's work it really should have > a Signed-off-by: Using wingrim's real name. Or maybe Wingrime wants to > submit this himself, please coordinate with him, at a minimum you need > a mail from him with this Signed-off-by (after which you can just copy that > one line from the email to your patch commit message). > > Regards, > > Hans > Thanks for the effort. Much appreciated, CK > > -- > You received this message because you are subscribed to the Google Groups > "linux-sunxi" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to linux-sunxi+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
