Hi Alexander, On Mon, Apr 28, 2014 at 3:35 PM, Александр Берсенев <b...@hackerdom.ru> wrote: > I fixed all known kernel oopses by placing spinlock in interrupt handler and > changing driver initialization order. > > Left to do: > 1) deal with timers > 2) support and testing on other platforms > > I am going away for few days for not being too noisy.
There's nothing wrong with being too noisy. If you have the time, please keep testing and working on this and reporting what you find. Oh, and a couple of administrative points: 1. Seriously think about splitting this up. It won't make it upstream without doing that and collecting approval from all the relevant subsystems. - that said, this can wait until you've dealt with the timer issues and added support (where relevant) for other boards. 2. You need to work a bit more on the non-code parts of your patch submissions, you need a short description at the very least. 3. You should start versioning your patches. 4. You also need to keep an eye open for any extra lines you add. 5. It's better to resubmit entire patches instead of small incremental patches on top of existing ones. Your next patch submission should look something like this: (Assuming what I've said is accurate) Subject: [PATCH v2] sunxi: Add support for consumer infrared devices Body: This patch introduces Consumer IR(CIR) support for sunxi boards. This is based on Alex Allss' work based on the original driver supplied by Allwinner. Signed-off-by: Alexander..... CC: wingrime@.... --- Changes since version 1: - Fix timer memory leaks - Tidy up code Etc. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ .Plan: http://sites.google.com/site/juliancalaby/ -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
