On Wed, Mar 11, 2020 at 11:23:27AM +0100, Pascal Roeleven wrote: > On 2020-03-10 19:54, Sam Ravnborg wrote: > > A few things to improve. > > > > The binding should be a separate patch. > > subject - shall start with dt-bindings: > > Shall be sent to deveicetree mailing list. > > Hi Sam, > > Thank you very much for your review. > I did consider this. The reason I combined the patches, is that the binding > depends on the display so I thought they were related in some way. Didn't > know the correct procedure to handle this. I will split them apart in v2.
FYI, checkpatch.pl will tell you both bindings should be a separate patch and that they should be in DT schema format. Rob -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/20200323212711.GA6856%40bogus.
