On Tue, 2024-08-27 at 18:21 +0200, Jan Kara wrote:
> On Tue 20-08-24 17:52:29, Julian Sun wrote:
> > Currently, the show_inode_state() macro only prints
> > part of the state of inode->i_state. Let’s improve it
> > to display more of its state.
> >
> > Signed-off-by: Julian Sun <sunjunchao2...@gmail.com>
> > ---
> > include/trace/events/writeback.h | 11 ++++++++++-
> > 1 file changed, 10 insertions(+), 1 deletion(-)
>
> Yeah, it could be useful at times. Some comments below.
>
> > @@ -20,7 +20,16 @@
> > {I_CLEAR, "I_CLEAR"}, \
> > {I_SYNC, "I_SYNC"}, \
> > {I_DIRTY_TIME, "I_DIRTY_TIME"}, \
> > - {I_REFERENCED, "I_REFERENCED"} \
> > + {I_REFERENCED, "I_REFERENCED"}, \
> > + {I_DIO_WAKEUP, "I_DIO_WAKEUP"}, \
>
> I_DIO_WAKEUP is never set and is being removed, please don't put it
> here.
>
> > + {I_LINKABLE, "I_LINKABLE"}, \
> > + {I_DIRTY_TIME, "I_DIRTY_TIME"}, \
>
> Um, I_DIRTY_TIME is already included.
>
> > + {I_WB_SWITCH, "I_WB_SWITCH"}, \
> > + {I_OVL_INUSE, "I_OVL_INUSE"}, \
> > + {I_CREATING, "I_CREATING"}, \
> > + {I_DONTCACHE, "I_DONTCACHE"}, \
> > + {I_SYNC_QUEUED, "I_SYNC_QUEUED"}, \
> > + {I_PINNING_NETFS_WB, "I_PINNING_NETFS_WB"} \
> > )
>
> Otherwise the patch looks good to me.
Thanks for your review and comments, I will fix them in patch v2.
>
> Honza
Thanks,
--
Julian Sun <sunjunchao2...@gmail.com>
