Hi, On 2/5/26 12:12 PM, Peter Zijlstra wrote: > On Thu, Feb 05, 2026 at 11:57:25AM +0100, Carlos López wrote: >> kmap_atomic() has been deprecated for a few years, and kmap_local_page() >> should be used instead, so replace it. Since the uprobes code relied on >> kmap_atomic() disabling page faults to access user pages, add the >> required calls to keep the existing behavior. > > Are those pagefault_disable()s really needed here, or is this just > cargo-culting?
The subsystem experts can correct me, but it seems to me this code is primarily accessing user memory, e.g. is_trap_at_addr() -> get_user_pages() -> uprobe_copy_from_page().
