On 02/05, Peter Zijlstra wrote: > > On Thu, Feb 05, 2026 at 11:57:25AM +0100, Carlos López wrote: > > kmap_atomic() has been deprecated for a few years, and kmap_local_page() > > should be used instead, so replace it. Since the uprobes code relied on > > kmap_atomic() disabling page faults to access user pages, add the > > required calls to keep the existing behavior. > > Are those pagefault_disable()s really needed here, or is this just > cargo-culting?
No, I think there are not needed. And the (already in tip) patches from Keke do not add pagefault_disable(). is_trap_at_addr() does pagefault_disable() because it is called with mm->mmap_lock held. Oleg.
