On 08-05-2026 19:31, Mark Brown wrote:
On Thu, May 07, 2026 at 11:03:39PM +0530, Praveen Talari wrote:
On 07-05-2026 13:43, Mark Brown wrote:
By generic I mean this should not be driver specific at all.
I hope these changes are fine. Please let me know if you have any concerns
or feedback.
The data tracepoints look plausible but I would expect them to be
generated by the core, they'll be there for everything so I'd expect
Thank you for the clarification. I now understand your point clearly.
Could you also please review the changes made in spi.c ?
I would appreciate any feedback or suggestions you may have.
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 91dd831d2d3b..f0d3665412fe 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -1658,6 +1658,11 @@ static int spi_transfer_one_message(struct
spi_controller *ctlr,
trace_spi_transfer_stop(msg, xfer);
+ if (spi_valid_txbuf(msg, xfer))
+ trace_spi_tx_data(msg->spi, xfer->tx_buf,
xfer->len);
+ if (spi_valid_rxbuf(msg, xfer))
+ trace_spi_rx_data(msg->spi, xfer->rx_buf,
xfer->len);
+
if (msg->status != -EINPROGRESS)
goto out;
Thanks,
Praveen Talari
them to work for everything.
