Hi Mark,
On 10-05-2026 18:07, Mark Brown wrote:
On Sat, May 09, 2026 at 07:37:26AM +0530, Praveen Talari wrote:
Could you also please review the changes made in spi.c ?
I would appreciate any feedback or suggestions you may have.
Please just sumbmit normal patches instead of sending partial patches in
reply to another thread unless something is really unclear.
@@ -1658,6 +1658,11 @@ static int spi_transfer_one_message(struct
spi_controller *ctlr,
trace_spi_transfer_stop(msg, xfer);
+ if (spi_valid_txbuf(msg, xfer))
+ trace_spi_tx_data(msg->spi, xfer->tx_buf,
xfer->len);
+ if (spi_valid_rxbuf(msg, xfer))
+ trace_spi_rx_data(msg->spi, xfer->rx_buf,
xfer->len);
It feels like it'd be more helpful to log the transmit data before we do
the send.
I can see that TX/RX data tracepoints are already present in the core
layer, so I will drop the TX/RX data tracepoints from this series. I
will update the patch set accordingly.
trace log from spi.c:
spi_transfer_start: spi16.0 00000000631b0da2 len=16
tx=[d8-07-1f-c4-b3-b3-07-d6-a8-7b-33-6f-7b-bb-ae-9b]
rx=[d8-07-1f-c4-b3-b3-07-d6-a8-7b-33-6f-7b-bb-ae-9b
Thanks,
Praveen Talari
