On 2015/1/14 17:55, Miklos Szeredi wrote: > On Wed, Jan 14, 2015 at 3:45 AM, hujianyang <hujiany...@huawei.com> wrote: >> Hi Miklos, >> >> I was considering the "FIXME: workdir is not needed for a R/O mount" >> you left in ovl_fill_super() these days. >> >> Actually Seunghun (Seunghun Lee <way...@gmail.com>) has sent a patch >> about these problem. But I have some different ideas. I think there are >> two ways to fix this problem. One, just remove this *FIXME*. Another, >> Allow non-workdir mount. >> >> 1) Remove *FIXME*; Further, use workdir in R/W case only >> >> As multi-layer mount are allowed in ovl, users could initialize a R/O >> mount by setting multi lower directories. Workdir should only be used >> in R/W case with upperdir exist. So this *FIXME* can be removed. >> >> We should add some information in the code and document about this. > > I'd vote for this. > > If there's no workdir, just use multiple lowedirs. > > If there is a workdir, then specify it (and overlay can still be > mounted R/O, possibly remounted R/W) >
Got it~! I'd like to send a patch about it tomorrow. By the way, I think we should add a error message in parse_opt, see the mail send by Fabian, do you agree with it? Thanks, Hu -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
