> From: Greg KH <[EMAIL PROTECTED]>
> To: [EMAIL PROTECTED]
> Date: Mon, 1 Oct 2001 11:37:50 -0700
> hub.c | 78
> hub.h | 17
The bulk of it is my semaphore that Alan adopted. Linus swore
like a sailor when he saw it, so it did not go in.
The following snippet is curious (Alan's tree has the unlock):
@@ -845,7 +838,6 @@
dbg("usb_hub_thread exiting");
- unlock_kernel();
complete_and_exit(&khubd_exited, 0);
}
I have no idea what is right, above.
Make sure Brad's copyright has the right bracket AT LAST.
- /* zaitcev RHbug #23670 - 1.5Mb/s mice die when switching VCs */
+ /* Some low speed devices have problems with the quick delay, so */
+ /* be a bit pessimistic with those devices. RHbug #23670 */
if (portstatus & USB_PORT_STAT_LOW_SPEED) {
I think my comment was laconic and to the point. Dunno why JE
spread it like this.
> uhci-common.h | 207 +
> uhci.c | 77
> uhci.h | 154 -
I heed this, and pieces that related to dev above it (ac tree is right):
--- linux-2.4.10-ac4/drivers/usb/uhci.c Tue Oct 2 12:37:40 2001
+++ linux-2.4.11-pre2/drivers/usb/uhci.c Mon Sep 10 08:06:32 2001
@@ -1580,14 +1578,8 @@
uhci_unlink_generic(uhci, urb);
uhci_destroy_urb_priv(urb);
- if (ret == 0) { /* N.B. Done, must notify */
- /* uhci_call_completion(urb); */ /* ->> uhci_destroy_urb_priv */-
urb->dev = NULL;
- if (urb->complete)
- urb->complete(urb);
- }
- usb_dec_dev_use(dev);
+ usb_dec_dev_use(urb->dev);
return ret;
}
The rest of it is normal JE's work, he ought to tell you himself.
> usb-uhci.c | 659 +++---
> usb-uhci.h | 179 -
In 2.4.10 Georg has removed urb->lock, so it is superior to -ac.
My and david-b's kludges are no longer necessary. Please take
Georg's version from Linus' tree.
> usb.c | 82
The bulk of the change is the correct way to do usb_control_msg().
Don't forget the change in <linux/usb.h>, it's related. Take
it from -ac.
The exportation of usb_get_status() is curious. Probably should
not hurt, unless you want to clamp down on interfaces that we export.
Ditto MODULE_LICENSE - I do not know if this is supported by Linus.
-- Pete
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
